Conversation
|
Ping @code-asher – https://github.com/coder/code-server/actions/runs/23541856157/job/68531271657?pr=7716#step:11:461 |
The target we have been using has started throwing all sorts of errors during the build (even without any of our patches). After checking the VS Code repo I think these are the ones we should actually be using. They are way faster, too.
d61f67d to
01734df
Compare
There was a problem hiding this comment.
I took a look at VS Code's GitHub workflows and it looks like they are using different build targets, so I tried those and it seems to be working.
Also these targets are way, way faster. 7.5-10 minutes instead of the hour+ it was before. Almost worried something must be wrong haha but I smoke tested it and everything seems to be working. Will probably make this one an RC first just in case.
Good idea. |
|
@code-asher Please note the size increase, e.g.
|
|
Aha yup I noticed that too and investigated. They are including a few new dependencies, The rest appears to be new files and source maps, but most of it seems to be those Copilot dependencies. |
|
I think actually we can strip some of that out, looking at how VS Code is building things. I will mess around with that tomorrow. |
|
Finally got it building with VS Code's packaging which does all the post-processing of modules. It is still bigger, 152 MB now, but I think that is just how big it is now. |
🤔 @code-asher Inspection of the tarballs ( v4.112.0: v4.113.0-rc.2: v4.113.0-rc.2_node_modules.txt v4.112.0: v4.113.0-rc.2: v4.112.0_lib_vscode_node_modules:
--- v4.112.0_lib_vscode_node_modules
+++ v4.113.0-rc.2_lib_vscode_node_modules
@@ -18,6 +18,7 @@
file-uri-to-path
fs-constants
fs-extra
+@github
github-from-package
graceful-fs
http-proxy-agent
@@ -44,7 +45,6 @@
ms
napi-build-utils
node-abi
-node-addon-api
node-pty
once
opentype.js
@@ -52,7 +52,6 @@
pend
picomatch
@pondwader
-prebuild-install
proxy-from-env
pump
rc
@@ -73,7 +72,6 @@
tas-client
tiny-inflate
@tootallnate
-tslib
tunnel-agent
@types
undici
@@ -81,10 +79,12 @@
util-deprecate
uuid
@vscode
+vscode-jsonrpc
vscode-oniguruma
vscode-regexpp
vscode-textmate
wrappy
+ws
@xterm
yallist
yauzlv4.112.0: v4.113.0-rc.2: v4.112.0: + v4.113.0-rc.2: |
|
Functionality [modified by patches] tested and found to work:
Workspaces and Jupyter Notebooks also work fine:
|
|
Thank you for testing it! I checked the git history and yeah looks like The removed modules line up with the But hmm the root modules went from 41 to 114 MB? Ohh this is definitely a mistake, I switched to |
|
@code-asher Thank you so much for your effort and your time. Highly appreciated! |
|
code-server: The size difference of the tarball files between versions 4.112.0 and 4.113.0-rc.3 is now 18 MB. (VS Code: The size difference of the tarball files between versions 1.112.0 and 1.113.0 is 11.1 MB) This looks reasonable. I will smoke test v4.113.0-rc.3 early next morning (CEST). |
|
I checked how it compared uncompressed with the official web build (on Codespaces): After poking around a bit, I suspect this difference is because we keep the source maps. Might be worth considering removing them, but I can look into that later. Edit: apparently the official build does have a few source maps, if I remove all Suspiciously way smaller without source maps... Double edit: I get a much closer match if I download the official web build locally, maybe the Codespaces one is built differently: Looks like most of that is because of the |
No description provided.